Skip to content

Detect browser OceanHero #6728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 12, 2021
Merged

Conversation

sanchezzzhak
Copy link
Collaborator

No description provided.

@sanchezzzhak sanchezzzhak requested a review from sgiehl April 27, 2021 20:15
@sgiehl
Copy link
Member

sgiehl commented May 12, 2021

That seems to be a chrome extension only. See https://chrome.google.com/webstore/detail/oceanhero-save-the-oceans/cdbccfkcpkmimlajcjpodelocoeifjhp
Or is there a custom chromium version available somewhere as well?

@sanchezzzhak
Copy link
Collaborator Author

for mobile devices, an application:
https://play.google.com/store/apps/details?id=com.oceanhero.search

@sgiehl
Copy link
Member

sgiehl commented May 12, 2021

I see. I've just installed that app and it actually uses this UA:

Mozilla/5.0 (Linux; Android 10) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/90.0.4430.91 Mobile OceanHero/6 Safari/537.36

So guess the other one is for the extension only

@sanchezzzhak
Copy link
Collaborator Author

I installed the extension on my computer useragent outputs - standard chrome
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.212 Safari/537.36

I can make a stricter rule
Android.+OceanHero/([\.\d]+)
do it?

@sgiehl
Copy link
Member

sgiehl commented May 12, 2021

Seems there is also a MacOS App: https://apps.apple.com/us/app/oceanhero/id1503330056?mt=12
Can't test it, but guess it's fine to keep it the way it is.

@sanchezzzhak sanchezzzhak enabled auto-merge May 12, 2021 07:35
@sanchezzzhak sanchezzzhak merged commit eb9c9b2 into matomo-org:master May 12, 2021
@sanchezzzhak sanchezzzhak deleted the pr_browser_4 branch September 3, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants