Skip to content

Improves detection for Samsung #6639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 128 commits into from
Feb 15, 2021
Merged

Improves detection for Samsung #6639

merged 128 commits into from
Feb 15, 2021

Conversation

liviuconcioiu
Copy link
Collaborator

No description provided.

@sanchezzzhak
Copy link
Collaborator

@liviuconcioiu It's hard to say.

Most Samsung table models are named in this format

tablet -
model name + (screen size) + (year) + network type (3G|4G|5G|WiFi|LTE)

I think it would be better to leave it as it is
pass Galaxy Tab S7+ 12.4" 5G
rename Galaxy Tab S6 10.4" Lite WiFi in Galaxy Tab S6 Lite 10.4" WiFi

@liviuconcioiu
Copy link
Collaborator Author

If so, then Galaxy Tab A 8.0" LTE (2018) should be changed to Galaxy Tab A 8.0" (2018) LTE right?

@sgiehl sgiehl enabled auto-merge (squash) February 15, 2021 20:21
@sgiehl sgiehl merged commit 6d1b8cf into matomo-org:master Feb 15, 2021
@liviuconcioiu liviuconcioiu deleted the samsung1 branch February 15, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants