Skip to content

Adds detection for various mobile apps and improves detection for iOS #6623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Feb 18, 2021
Merged

Adds detection for various mobile apps and improves detection for iOS #6623

merged 40 commits into from
Feb 18, 2021

Conversation

liviuconcioiu
Copy link
Collaborator

No description provided.

@liviuconcioiu liviuconcioiu changed the title Adds detection for various mobile apps Adds detection for various mobile apps and improves detection for iOS Feb 5, 2021
@liviuconcioiu
Copy link
Collaborator Author

I think I should write a regex rule for each Microsoft Office app, since in README.md, is seen as
Microsoft Office $1
https://github.com/matomo-org/device-detector#list-of-detected-mobile-apps

sanchezzzhak
sanchezzzhak previously approved these changes Feb 7, 2021
@@ -185,7 +185,7 @@
- regex: 'BingWeb/([\d\.]+)?'
name: 'BingWebApp'
version: '$1'
- regex: 'GSA/([\d\.]+)?'
- regex: '(?:com.google.GoogleMobile|GSA)/([\d\.]+)?'
Copy link
Collaborator

@sanchezzzhak sanchezzzhak Feb 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note:
the maximum version I could find in the logs is dated 2019.02
google.com.GoogleMobile/67.1.0 for iPhone/12.1.3 for iPhone7_2

if compare version 67 with the release date 2019.02.16 and take useragent from the log 2019.02 - then everything fits together

Website https://iphone.apkpure.com/google/com.google.googlemobile there I looked at the app versions ( appstore is limited to the list of versions)

@sanchezzzhak sanchezzzhak merged commit 0e56e9a into matomo-org:master Feb 18, 2021
@liviuconcioiu liviuconcioiu deleted the apps branch February 18, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants