Skip to content

Detect devices for brands: LG, Fujitsu, Chuwi, Sharp, FireFly Mobile, and create ExtraYaml check is not key number #6690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 25, 2021
Merged

Detect devices for brands: LG, Fujitsu, Chuwi, Sharp, FireFly Mobile, and create ExtraYaml check is not key number #6690

merged 8 commits into from
Feb 25, 2021

Conversation

sanchezzzhak
Copy link
Collaborator

No description provided.

@sanchezzzhak
feat(device) detect brand LG model: Optimus it L-05E
025e850 
feat(device) detect brand Fujitsu model: Easy Phone F-01M
feat(device) detect brand Fujitsu model: Easy Phone F-01M
feat(device) detect brand Sharp model: Aquos Keitai 10 (NP807SH)
feat(device) detect brand Chuwi model: V99I (CW-V99I)
feat(device) detect brand FireFly Mobile models: Aurii Delight, Aurii Dream Mini, Aurii Dream One
@sanchezzzhak
Merge remote-tracking branch 'upstream/master' into pr_device_89
bb34ebd
@sanchezzzhak
feat(test) create extra YAML test check key is not number
6427865
@sanchezzzhak sanchezzzhak requested a review from sgiehl February 25, 2021 12:05
@sanchezzzhak
Copy link
Collaborator Author

sanchezzzhak commented Feb 25, 2021 •
edited
Loading

@sgiehl need to check only the float key?

@sgiehl
Copy link
Member

sgiehl commented Feb 25, 2021

@sgiehl need to check only the float key?

Actually not sure, if that might also be the case for decimals. The error with symfony was:

PHP message: PHP Fatal error:  Uncaught Symfony\Component\Yaml\Exception\ParseException: Numeric keys are not supported. Quote your evaluable mapping keys instead at line 1305 (near "5.2: 'Blink'"). in /var/www/devicedetector/vendor/symfony/yaml/Parser.php:224

sanchezzzhak
sanchezzzhak commented Feb 25, 2021
View reviewed changes
sgiehl
sgiehl reviewed Feb 25, 2021
View reviewed changes
sanchezzzhak and others added 2 commits February 25, 2021 17:42
sgiehl
sgiehl reviewed Feb 25, 2021
View reviewed changes
@sanchezzzhak sanchezzzhak merged commit 3794d7b into matomo-org:master Feb 25, 2021
@sanchezzzhak sanchezzzhak deleted the pr_device_89 branch February 25, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanchezzzhak @sgiehl