Skip to content

Adds detection for JavaFX WebView #6665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 25, 2021
Merged

Adds detection for JavaFX WebView #6665

merged 13 commits into from
Feb 25, 2021

Conversation

liviuconcioiu
Copy link
Collaborator

No description provided.

@sanchezzzhak sanchezzzhak requested a review from sgiehl February 24, 2021 14:55
@sgiehl
Copy link
Member

sgiehl commented Feb 24, 2021

@sanchezzzhak Looks good to me. Should we add a WebView to the name, so it's clear it's an embedded browser? Don't have a strong opinion on that...

@sanchezzzhak
Copy link
Collaborator

I looked at 3 projects, how they define this string.
51degrees: does not detect
WhichBrowser: JavaFX
udger: JavaFX

sanchezzzhak
sanchezzzhak previously approved these changes Feb 24, 2021
@sanchezzzhak sanchezzzhak merged commit 22254fd into matomo-org:master Feb 25, 2021
@liviuconcioiu liviuconcioiu deleted the javafx branch February 25, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants