-
Notifications
You must be signed in to change notification settings - Fork 497
Introduce Yaml Lint check to prevent errors in yml files #6434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might even be better. Thanks for the change.
Not sure how helpful error messages like this are:
|
@sgiehl Is it possible to make a more detailed error reports in YAML Lint? |
Interestingly running
I see now that it shows an inline block in https://github.com/matomo-org/device-detector/pull/6434/files#diff-1c8c04e817f8cf3650ade17a6d2a3080093d82d90fc1ecd8e2919e1f74c0e88fR17576, but only after uncollapsing the mobiles.yml section. And one has to look at https://github.com/matomo-org/device-detector/actions/runs/374180337 instead of https://github.com/matomo-org/device-detector/actions/runs/374180337 to see the nice overview of errors. |
as @Findus23 mentioned. The errors should be highlighted in the diff on github. Guess there's not much that can be changed on the error messages. But imho that should be enough... we should at least now see if any yml file is broken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me
fixes #6433