Adds detection for Flow browser engine and for Flow browser #6467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The engine version is not seen correctly. I tried multiple regexes and all failed. I think there is a bug in |
sanchezzzhak
previously approved these changes
Dec 2, 2020
There was a problem hiding this comment.
According to this news they use their own engine
https://www.ekioh.com/news/ekioh-launches-the-worlds-first-multithreaded-embedded-browser/
rv gecko (RenderVersion) is equal to the Firefox version, starting from the browser version 3.6+
The presence of FF + Gecko is a formality so that the browser is not blocked by sites.
sgiehl
requested changes
Dec 3, 2020
sanchezzzhak
approved these changes
Jan 6, 2021
sanchezzzhak
requested changes
Jan 6, 2021
sanchezzzhak
approved these changes
Jan 6, 2021
sanchezzzhak
requested changes
Jan 7, 2021
sanchezzzhak
previously approved these changes
Jan 8, 2021
sgiehl
reviewed
Jan 8, 2021
|
@sanchezzzhak I guess this one would be good to merge, right? |
|
Yes |
sgiehl
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.