Detect new brand: Soundmax; Detect old devices model for brand Samsung; #6332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…M11S; feat(device) detect brand Samsung models: GALAXY A50 (SM-A505U), GALAXY A6 (SM-A600U), GALAXY A6+ (SM-A6050), GALAXY A60 (SM-A6060), GALAXY A7 (2018) (SM-A750N), GALAXY J1 mini Prime (SM-J106H, SM-J106B), GALAXY Folder 2 (SM-G1600), GALAXY Note 5 (SM-N920P), GALAXY Note 4 LTE (SM-N916L), GALAXY A9 Pro (SM-G887N), GALAXY J7 (2016) (SM-J710GN, SM-J7109), GALAXY Note 5 (SM-N920F), GALAXY Golden 3 (SM-W2016), GALAXY On7 Prime (SM-G611K, M-G611L), GALAXY J3 (2016) (SM-J320R4, SM-J320W8) issue matomo-org#6328
GALAXY A50s (SM-A507FN), GALAXY S10 (SM-G977U, SM-G977P, SM-G977N), GALAXY S10+ (SM-G975X, SM-G975N) issue matomo-org#6328
…7070 (SM-A7070), GALAXY A80 (SM-A8050, SM-A805F, SM-A805N, SM-A805X), GALAXY A90 (SM-A908B, SM-A908N), GALAXY A9 (2018) (SM-A9200), GALAXY Fold (SM-F900F, SM-F900U, SM-F907B, SM-F907N), GALAXY Xcover 4 (SM-G390W) issue matomo-org#6328
…AZ), GALAXY J3 Prime (SM-J327A, SM-J327T, SM-J327W), GALAXY J5 Prime (SM-G5700), GALAXY S8+ (SM-G955X), GALAXY J3 Emerge (SM-J327F, SM-J327R4), GALAXY J3 (2017) (SM-J327R7, SM-J327U) issue matomo-org#6328
GALAXY Tab S2 8.0" WiFi (SM-T710, SM-T713). GALAXY Tab S2 8.0" LTE (SM-T715), GALAXY J7 (2017) (SM-J727F), GALAXY A5 (2015) (SM-A500X), GALAXY A5 (2016) (SM-A5108) issue matomo-org#6328
…SM-N976N), GALAXY A10e (SM-S102DL), GALAXY M20 (SM-M205N), GALAXY J7 Crown (SM-S767VL), GALAXY J2 Core (SM-S260DL), GALAXY Note 10 (SM-N971N, SM-N970W). GALAXY M10s (SM-M107F) issue matomo-org#6328
…415N, SM-J415G), GALAXY J7 (2018) (SM-J737R4), GALAXY Tab S6 10.5" (SM-T865N, SM-T865), GALAXY Tab S6 10.5" WiFi (SM-T860), GALAXY Tab S4 10.5" (SM-T837V), GALAXY J2 Pro (SM-J250G, SM-J250Y), GALAXY J3 (2017) (SM-J3300, SM-J3308), GALAXY S10 Lite (SM-G770F), GALAXY Note 10 Lite (SM-N770F, SM-N770X), GALAXY Tab S6 10.4" Lite (SM-P615), GALAXY Tab S6 10.4" Lite WiFi (SM-P610), GALAXY M20 (SM-M205M), GALAXY M01 (SM-M015G), GALAXY A8s (SM-G8870) issue matomo-org#6328
GALAXY A71 (SM-A715F, SM-A715W), GALAXY Xcover Pro (SM-G715FN), GALAXY Xcover 4s (SM-G398FN), GALAXY A9 Star (SM-G8850), GALAXY A70s (SM-A707F), GALAXY Note 10+ (SM-N976Q), GALAXY S10 (SM-G977B), GALAXY S9 (SM-G960), GALAXY A6+ (SM-A6058), GALAXY A20s (SM-A2070), GALAXY A01 (SM-A015A), GALAXY Note 3 LTE (SM-9005), GALAXY A8s (SM-G887F), GALAXY Win Pro (SM-G3812), GALAXY Tab S2 9.7" LTE (SM-T819, SM-T819Y), GALAXY Tab 3 7.0" (SM-T215), GALAXY Tab 3 7.0" Kids (SM-T212), GALAXY Tab S4 10.5" (SM-T837T), GALAXY Tab S2 8.0" LTE (SM-T715Y), GALAXY Grand Prime (SM-G5308W, SM-G530BT, SM-G530M, SM-G530MU) issue matomo-org#6328
…M-T830X), GALAXY J5 (2016) (SM-G510H), GALAXY Tab 4 7.0" LTE (SM-T239), GALAXY Tab 3 7.0" Lite WiFi (SM-T113), GALAXY Tab S4 10.5" (SM-T837A, SM-T835N, SM-T835C), GALAXY Tab S4 10.5" WiFi (SM-T830), GALAXY Avant (SM-G386T1), GALAXY Tab S5e 10.5" WiFi (SM-T720, SM-T720X, SM-T725N, SM-T727A, SM-T727V), GALAXY J3 (2018) (SM-J337A), GALAXY A50 (SM-S506DL), GALAXY Tab A 8.0" WiFi (2019) (SM-T290), GALAXY Tab A 10.1" LTE (2016) (SM-T587), issue matomo-org#6328
…SM-J337AZ), GALAXY J3 (2018) (SM-J337P, SM-J337U, SM-J337V), GALAXY J3 Aura (SM-J337R4), GALAXY J3 Star (SM-J337T), GALAXY Tab S3 9.7" LTE (SM-T827), GALAXY J1 (SM-J100Y), GALAXY J1 Ace (SM-J110G), GALAXY A3 (2015) (SM-A3009), GALAXY Core LTE (SM-G386W), GALAXY Avant (SM-G386T), GALAXY Ace Style (SM-G357M), GALAXY Tab A 10.1" LTE (2016) (SM-T587P), GALAXY Tab A 8.0" LTE (2018), GALAXY Tab A 10.1" LTE (2016) (SM-T387W), GALAXY A10e (SM-A102U), GALAXY M10 (SM-M105M) issue matomo-org#6328
GALAXY Tab A 8.0" LTE (2018) (SM-T387VK, SM-T387V, SM-T387T), GALAXY J3 Luna Pro (SM-S337TL), GALAXY J7 Sky Pro (SM-S737TL), GALAXY Tab S 10.5" LTE (SM-T807V, SM-T807P, SM-T807), GALAXY Tab E 8.0" (SM-T378L, SM-T378S), GALAXY Tab E 9.6" 4G (SM-T567V), GALAXY Tab 4 10.1" Advanced (SM-T536), GALAXY Note 4 (SM-910U), GALAXY Note 5 (SM-N920R4, SM-N920W8) issue matomo-org#6328
1 task
sgiehl
approved these changes
Jul 27, 2020
| @@ -10416,11 +10466,13 @@ Samsung: | |||
| model: 'GALAXY Centura' | |||
| - regex: 'vollo Vi86[);/ ]' | |||
| model: 'Vollo Vi86' | |||
| - regex: '(?:SAMSUNG-)?SM-A015[FGM]' | |||
| - regex: '(?:SAMSUNG-)?SM-G386(?:T1|T)' | |||
There was a problem hiding this comment.
Not important, but wouldn't (?:SAMSUNG-)?SM-G386T1? actually be the same?
Feel free to change that in a later PR if you like
There was a problem hiding this comment.
Samsung has a very complex model naming system.
where the first 4 characters after SM are the model code, and all the other letters are not really important.
SM-G386TRKATMB all variants SM-G386 (?:TRKATMB]+)[);/ ] or SM-G386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.