Skip to content

Detect browser: Opera when it disguises itself as Firefox and fixes parser for Gecko version #6382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 2, 2020

Conversation

sanchezzzhak
Copy link
Collaborator

No description provided.

@sanchezzzhak sanchezzzhak linked an issue Oct 1, 2020 that may be closed by this pull request
@sanchezzzhak
Copy link
Collaborator Author

sanchezzzhak commented Oct 1, 2020

Should we convert the release date version to the version?
Gecko/20100101 => 1.9.2
https://developer.mozilla.org/en-US/docs/Mozilla/Gecko/Versions
https://de.wikipedia.org/wiki/Versionsgeschichte_von_Mozilla_Firefox

@sgiehl
Copy link
Member

sgiehl commented Oct 1, 2020

Should we convert the release date version to the version?

If it's easy possible, why not...

@sanchezzzhak
Copy link
Collaborator Author

sanchezzzhak commented Oct 1, 2020

@sgiehl done, I followed this documentation
https://developer.mozilla.org/en-US/docs/Mozilla/Gecko/Versions

@sgiehl sgiehl merged commit 5be74a5 into matomo-org:master Oct 2, 2020
@sanchezzzhak sanchezzzhak deleted the 6290 branch October 4, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Gecko layout engine version is not parsing
2 participants