Skip to content

feat(device) detect Samsung GALAXY Note 20 5G #6370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2020
Merged

Conversation

@sanchezzzhak
Copy link
Collaborator

sanchezzzhak commented Sep 20, 2020

Additional useragents that can be added to tests (optional)

  • Mozilla/5.0 (Linux; Android 10; SM-N981U) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.101 Mobile Safari/537.36
  • Mozilla/5.0 (Linux; Android 10; SM-N981U1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.125 Mobile Safari/537.36
  • Mozilla/5.0 (Linux; Android 10; SM-N981W) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.81 Mobile Safari/537.36

useragent is not being processed

  • Mozilla/5.0 (Linux; Android 10; SM-N981N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.125 Mobile Safari/537.36

@pongee
Copy link
Contributor Author

pongee commented Sep 21, 2020

Thank you sanchezzzhak.
I added these user agent as well, and added SM-N981N.

@sgiehl sgiehl merged commit 14a0f03 into matomo-org:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants