-
Notifications
You must be signed in to change notification settings - Fork 495
Detect new brands: Minix, Winds, Asano, MyTab, Phonemax and detect new bot Seobility and Detect devices for existing brands: Asus, Aligator, BQ, Bravis, Ergo, HTC, Polaroid, Highscreen, Ulefone, Doodgee and Pixus #6347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EO X88i, NEO X5 Mini, NEO X8H Plus, NEO X7 Mini, NEO X8H feat(device) detect brand Samsung model: GALAXY Tab 3 7.0" Lite (SM-T111M)
feat(device) detect brand Highscreen model: Power Rage
feat(device) detect brand Bravis model: S500 Diamond
feat(device) detect brand BQ models: Сharm Plus (BQ-7040G), Fox Power (BQru-4583); feat(device) detect brand Ergo model: B503 Optima; feat(device) detect brand HTC model: One E8 (0PAJ5); feat(device) detect brand Ulefone model: Gemini Pro; feat(device) detect brand Polaroid model: Sigma 5
…7081), Shark Rush (BQ-5541L)
…s (BQ-7038G) feat(device) detect brand Pixus model: HiMax 9.6" feat(device) detect brand Highscreen model: Power Five Evo
…532 3G CS1144MG, CITI 1576 3G CS1194MG feat(device) detect brand Nobby model: S300 Pro
feat(device) detect brand Nous model: NS5511 feat(device) detect brand Redmi model: Note 8 Pro
sgiehl
requested changes
Aug 14, 2020
regexes/device/mobiles.yml
Outdated
device: 'smartphone' | ||
models: | ||
- regex: 'B502 Basic' | ||
model: 'B502 Basic' | ||
- regex: 'A503-Optima' | ||
model: 'B503 Optima' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a mistake, I'm already fixing it
Closed
sgiehl
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.