Adds detection for multiple notebooks #6292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimmi20
suggested changes
May 5, 2020
|
@liviuconcioiu I'm not sure if we should add a new device type notebook 🤔 Nowadays most people are using notebooks, but most of the can't be detected as such and will be shown as desktop. Starting to detect some of them as notebooks now (and only those using facebook), might give a wrong insight |
|
I see. I will move them to desktop then. |
|
@liviuconcioiu I'll merge this to a local branch an recreate the PR with the required changes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.