Skip to content

Adds detection for PlayStation 4 Pro console #6250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2020
Merged

Adds detection for PlayStation 4 Pro console #6250

merged 2 commits into from
Apr 29, 2020

Conversation

liviuconcioiu
Copy link
Collaborator

No description provided.

@liviuconcioiu
Copy link
Collaborator Author

liviuconcioiu commented Apr 13, 2020 •
edited
Loading 

  os:
    name: PlayStation
    short_name: PS3
    version: "4"
    platform: ""

Here should be 4 Pro but I don't know why it shows that.

@sgiehl
Copy link
Member

sgiehl commented Apr 13, 2020

@liviuconcioiu that actually the operating system. Guess that doesn't differ between 4 and 4 Pro, does it?

@liviuconcioiu
Copy link
Collaborator Author

I've looked into the previous added consoles and I've seen their model added there. I just assumed that field should be 4 Pro. On the other hand, PS4 runs on Orbis OS, and PS3 runs on Cell OS. Shouldn't those values be added as default, instead of the ones that are now?

@sgiehl
Copy link
Member

sgiehl commented Apr 14, 2020

@liviuconcioiu feel free to change the OS names detected for PlayStation if they are wrong...

@sgiehl sgiehl merged commit 6ba9baa into matomo-org:master Apr 29, 2020
@liviuconcioiu liviuconcioiu deleted the ps4pro branch April 29, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liviuconcioiu @sgiehl