Add some browsers #6019
Merged
Add some browsers #6019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
requested changes
Aug 26, 2019
There was a problem hiding this comment.
Left a few comments. Also there are currently a lot tests failing. Can't merge until they are fixed.
For upcoming PRs: If you have multiple changes that are affecting many existing test fixtures it would be awesome if you could split up them up into multiple PRs. That makes it much easier to look through the changes
sgiehl
reviewed
Aug 27, 2019
|
I moved SeaMoney and Iceape to the pim section, and removed gnuzilla. The mentioned useragent matched to IceCat. |
sgiehl
reviewed
Sep 1, 2019
sgiehl
reviewed
Sep 1, 2019
|
awesome. tests are passing again. will merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These browsers were added:
For Firefox and Opera Mini the iOS variants were seperated because of the different versioning.
Chrome Webviewis seperated from Chrome because a lot of third party apps are using this UA.