Skip to content

#5980 Detect Browser Firefox Rocket #5992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2019
Merged

Conversation

sanchezzzhak
Copy link
Collaborator

No description provided.

@sanchezzzhak sanchezzzhak changed the title 5980 Detect Browser Firefox Rocket #5980 Detect Browser Firefox Rocket Jul 22, 2019
@Findus23
Copy link
Collaborator

As I explained in #5980, Firefox Rocket is essentially a webview using the Android system Webkit renderer. So it doesn't use Chromium source code but essentially it is using Chromium to render the page.
I wouldn't add it to the chrome-base list, but to the webkit one.

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Findus23 should we add it to the Firefox browser family? The rendering engine is detected separately.

@Findus23
Copy link
Collaborator

Hm, it makes sense for people to expect this category as "Browsers Mozilla develops under the Firefox brand" and therefore it should be in the Firefox family.

@sgiehl sgiehl merged commit 68d886d into matomo-org:master Jul 22, 2019
@sanchezzzhak sanchezzzhak deleted the 5980 branch July 22, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants