Skip to content

Added Beaker Browser #5894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Added Beaker Browser #5894

merged 2 commits into from
Feb 4, 2019

Conversation

da2x
Copy link
Contributor

@da2x da2x commented Jan 27, 2019

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) BeakerBrowser/0.8.2 Chrome/66.0.3359.181 Electron/3.0.9
Safari/537.36

https://beakerbrowser.com/

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you maybe also add a test for the new Browser?

@@ -5,6 +5,14 @@
# @license http://www.gnu.org/licenses/lgpl.html LGPL v3 or later
###############

# Beaker distributed web browser (https://beakerbrowser.com/)
- regex: 'Beaker ?Browser(?:[/ ](\d+[\.\d]+))?''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one ' to much at the end

da2x added 2 commits February 2, 2019 19:11
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML,
like Gecko) BeakerBrowser/0.8.2 Chrome/66.0.3359.181 Electron/3.0.9
Safari/537.36
@da2x
Copy link
Contributor Author

da2x commented Feb 2, 2019

Fixed mistakes, resolved conflicts, and added a test.

@sgiehl sgiehl merged commit 78d4ada into matomo-org:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants