Improves detection of various Bmobile devices #5852
Conversation
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
| - regex: 'AX-340' | ||
| model: 'AX340' | ||
| - regex: 'AX7OO' | ||
| model: 'AX700' |
There was a problem hiding this comment.
Are there any devices of other brands starting with AX? Otherwise we maybe could simplify the whole detections by using AX-?([1-9][0-9]{2,3}) for all and in the overall match
|
From what I've seen there is only one, |
|
ok. but that wouldn't match the regex I mentioned before |
Improves detection of various Bmobile devices
regexes/device/mobiles.yml
Outdated
| @@ -1407,17 +1407,11 @@ Blaupunkt: | |||
|
|
|||
| # Bmobile | |||
| Bmobile: | |||
| regex: 'Bmobile[_ ]|AX10(?:[1234567]0|[1345678]5|16|65E|70e|73\+|7[1234]|91)|AX(?:5[12347]0|512|5[123]5|524|6[01256789]0|[67]05|675|68[0135]|680\+|710|745|810|82[013]|92[012])|AX-340|AX7OO' | |||
| regex: 'Bmobile[_ ]|AX-?([1-9][0-9eEO+]{2,4})' | |||
There was a problem hiding this comment.
I guess the eEO+ can only be at the end, right? So maybe we should use AX-?([1-9][0-9]{2,3}[eEO+])
There was a problem hiding this comment.
You forgot to add a ? sign. Also, they made a typo mistake on the user agent, instead of 700 they wrote 7OO, but on their website the model is 700. I think this is the final regex AX-?([1-9][0-9]{2,3}[eEO+]?|7OO)
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices