Improved detection of Sony TV models #5718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RegEx now detects SONY KDL-65W859C SONY KD-55XD8577
sgiehl
reviewed
Mar 19, 2018
regexes/device/televisions.yml
Outdated
| @@ -213,7 +213,7 @@ Sony: | |||
| regex: 'Sony' | |||
| device: 'tv' | |||
| models: | |||
| - regex: '(KDL[0-9]{2}[A-Z]{1,2}[0-9]{3})' | |||
| - regex: '(KD[L\-]{0,2}[0-9]{2}[A-Z]{1,2}[0-9]{3,4}[A-Z]{0,1})' | |||
There was a problem hiding this comment.
KD[L\-]{0,2}
This might match incorrect stuff, as it also matches KDLL, KD-L or KD-- Guess it should match KDL, KDL-, KD and KD-, so try KDL?-?
And instead of {0,1} your could simply use a ?
|
Thank you for Your help. I'm new to regex but I need this for work. |
|
RegEx now ignores last letter(not numeric) in KDL-65W859C -> KDL-65W859 so it does not conflict with other models. |
|
I've added the user agents you mentioned above as new tests to prove they will work in the future. |
|
Thank You for Your help. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RegEx now detects
SONY KDL-65W859C as
KDL-65W859Mozilla/5.0 (Linux armv7l) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36 OPR/22.0.1481.0 OMI/4.2.12.48.ALSAN3.122 HbbTV/1.2.1 (; Sony; KDL-65W859C; v3.925; 2015;) sony.hbbtv.tv.2015HESONY KD-55XD8577 as
KD-55XD8577Mozilla/5.0 (Linux armv7l) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36 OPR/22.0.1481.0 OMI/4.2.12.48.ALSAN3.122 HbbTV/1.2.1 (; Sony; KD-55XD8577; v3.925; 2015;) sony.hbbtv.tv.2015HE