Lenovo tab4 and sentry #5709
Merged
Lenovo tab4 and sentry #5709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
requested changes
Feb 8, 2018
regexes/device/mobiles.yml
Outdated
| @@ -3067,6 +3067,12 @@ Lenovo: | |||
| - regex: 'Yoga Tablet([^;/]+) Build' | |||
| model: 'Yoga Tablet$1' | |||
| device: 'tablet' | |||
| - regex: 'Lenovo TB\-X704F Build/NMF26F' | |||
| model: 'Lenovo Tab 4 10 Plus' | |||
There was a problem hiding this comment.
would you remove the brand name from the model name? The model should only be Tab 4 10 Plus.
regexes/device/mobiles.yml
Outdated
| - regex: 'Lenovo TB\-X704F Build/NMF26F' | ||
| model: 'Lenovo Tab 4 10 Plus' | ||
| device: 'tablet' | ||
| - regex: '(Lenovo TB[0-9]?\-[a-z0-9\-]+) Build' |
There was a problem hiding this comment.
Please exclude the brand name from the match by using (TB[0-9]?\-[a-z0-9\-]+) Build. There's no need to match Lenovo at all, as this is already done with the base regex for the brand.
sgiehl
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.