Providing detection of iOS 10 and 11 #5789
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Do you have sample useragents for those versions, so we could add some tests? |
|
Oh man... sorry. I've checked some random commits updating the regexes and haven't found any tests - so I thought that you don't test all minor rules updates like this one. I may update the tests if you like. |
|
@wronan Thanks again for your approach. I've copied and improved your changes to a new branch, where I've also added some tests. Will create a PR soon and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the wildcards in minor version checks - I wasn't able to figure out specific versions. Still, better then nothing :)