Added a few Android devices #5766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
requested changes
Jul 16, 2018
regexes/device/mobiles.yml
Outdated
| - regex: '(?:SAMSUNG-)?SM-J111[FGLM]' | ||
| - regex: '(?:SAMSUNG-)?SM-J110[FHML]' | ||
| model: 'GALAXY J1 Ace' | ||
| - regex: '(?:SAMSUNG-)?SM-J111F' |
There was a problem hiding this comment.
Did you remove J111[GLM] on purpose?
There was a problem hiding this comment.
I don't think they actually exist: couldn't find information on those on the internet, and there were no tests/user-agents on them.
There was a problem hiding this comment.
There seems to be at least a SM-J111M (see https://www.handsetdetection.com/device-detection-database/devices/samsung/sm-j111m/)
There was a problem hiding this comment.
Ok, indeed, added this one back!
regexes/device/mobiles.yml
Outdated
| - regex: 'P008 Build[);/ ]' | ||
| model: 'ZenPad Z8' | ||
| device: 'tablet' | ||
| - regex: 'P027 Build[);/ ]' |
There was a problem hiding this comment.
having the [);/ ] here is not really needed, as it is already matched in the overall regex and Pxxx Build should be enough for an exact match then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.