Added some Android devices #5747
Conversation
regexes/device/mobiles.yml
Outdated
| model: 'GALAXY Grand 2' | ||
| device: 'phablet' | ||
| - regex: '(?:SAMSUNG-)?SM-G53(?:0F|0FZ|0Y|0H|0FZ|1F|1H)' | ||
| model: 'GALAXY Grand Prime' | ||
| device: 'phablet' | ||
| - regex: '(?:SAMSUNG-)?SM-G532F' | ||
| model: 'GALAXY Grand Prime Plus' | ||
| model: 'GALAXY J2 Prime/Grand Prime Plus' |
There was a problem hiding this comment.
We should decide to use only one name here. Maybe the more familiar / common name if possible.
There was a problem hiding this comment.
I don't disagree, but I could not decide as both "Grand Prime" and "J2" exist as other variants, and I don't know if one of these two is more popular.
regexes/device/mobiles.yml
Outdated
| - regex: '(?:SAMSUNG-)?SM-J730(?:F|G|GM)' | ||
| model: 'GALAXY J7 Pro' | ||
| - regex: '(?:SAMSUNG-)?SM-J701(?:F|M)' | ||
| model: 'GALAXY J7 Nxt/Neo/Core' |
There was a problem hiding this comment.
would use one of the names only here as well
There was a problem hiding this comment.
Same as the other comment: I don't disagree, but don't know which one could be best...
The names for this one seem to be different by region:
- Nxt in India
- Neo in LATAM
- Core in Philippines
|
@sgiehl So, what would you suggest regarding your comments? |
|
@GregOriol sorry for the delay. To be honest I'm not sure how to handle that best. But using multiple names might be a bit long. Maybe we could use the model name having most google results? |
|
Names simplified using Google results, I left the alternatives as comments in the yaml, so we can remember/find them later if trends change. |
regexes/device/mobiles.yml
Outdated
| model: 'V20' | ||
| - regex: '(?:LG-)?LS997' | ||
| model: 'V20' | ||
| - regex: '(?:LG-)?VS995' |
There was a problem hiding this comment.
this one seems to be a duplication.
There was a problem hiding this comment.
Do you prefer to regroup them into a single regex?
There was a problem hiding this comment.
that's not necessarily needed. but this specific regex is already done some lines before
No description provided.