Python3 port for device-detector #5741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe these should still work correctly on regex engines in the other languages represented.
|
detection improvements and new ports are always welcome 👍 |
GregOriol
pushed a commit
to GregOriol/device-detector
that referenced
this pull request
Jun 6, 2018
* Add python port to "other languages" list * Tweak regexes and fixtures for compability with Python port I believe these should still work correctly on regex engines in the other languages represented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the excellent library.
The regexes would be very useful in one of my projects so I ported to Python. Hope it can be a useful contribution to your work.