-
Notifications
You must be signed in to change notification settings - Fork 495
Description
I am in the process of adding some new user agents for the Roblox mobile app.
On Android, the system information isn't in the usual format. This is Android 10, as indicated by the "10" after the phone model.
Mozilla/5.0 (2822MB; 720x1411; 320x319; 411x806; Samsung SM-A115F; 10) AppleWebKit/537.36 (KHTML, like Gecko) ROBLOX Android App 2.448.411159 Phone Hybrid() GooglePlayStore RobloxApp/2.448.411159 (GlobalDist; GooglePlayStore)
Unfortunately, this user agent returns the Android version as 2.448.411159. The Android regex is matching 'Android App 2.448.411159'.
My understanding of the code is that once a regex matches, it will stop checking further regexes. Therefore, a workaround would be to change the current Android regex to (?:(?:Orca-)?Android|Adr)[ /](?!App)(?:[a-z]+ )?(\d+[\.\d]*)
and add a new regex to oss.yml
for this app. However as this is an edge case, I wanted to raise it as an issue first.