Skip to content

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 19, 2023

Description:

Review

Co-authored-by: Michal Kleiner <mk@011.nz>
@bx80 bx80 requested a review from michalkleiner April 26, 2023 23:55
@michalkleiner
Copy link
Contributor

The guide looks good from my perspective. I've left some minor suggestions and one or two questions in the inline comments, nothing major.

bx80 and others added 21 commits May 2, 2023 09:18
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
@sgiehl
Copy link
Member Author

sgiehl commented May 2, 2023

I'll merge this one now. We though might need to update the migration guide later again if additional breaking changes are merged to core.

@sgiehl sgiehl marked this pull request as ready for review May 2, 2023 12:02
@sgiehl sgiehl merged commit b07da16 into live May 2, 2023
@sgiehl sgiehl deleted the migration branch May 2, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants