Skip to content

only run JS tests for single plugin if PLUGIN_NAME is defined #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

diosmosis
Copy link
Member

Description:

Using the new --plugin=... parameter to make sure plugin builds only run tests for their specific plugin, so failures in other plugins do not affect the plugin build's status.

Review

@diosmosis diosmosis added the Needs Review For pull requests that need a code review. label Jun 13, 2023
@michalkleiner michalkleiner merged commit f2401c4 into main Jun 13, 2023
@michalkleiner michalkleiner deleted the js-tests-plugin branch June 13, 2023 22:33
@sgiehl
Copy link
Member

sgiehl commented Jun 14, 2023

Note: We maybe should use the --plugin option with care. It will also prevent the core javascript tests from running. But imho it can be useful to know if the core javascript tests are still running if a certain plugin is used.

@diosmosis
Copy link
Member Author

Why would core javascript tests need to be run in a plugin build? Or why would we need to know if the core tests are still run in the build for a plugin?

@sgiehl
Copy link
Member

sgiehl commented Jun 15, 2023

A plugin might break the core tracking even with having succeeding JavaScript plugin tests. Running core tests might show that.

@diosmosis
Copy link
Member Author

How would it break core tracking? Through tracker events? Or something else?

@sgiehl
Copy link
Member

sgiehl commented Jun 15, 2023

Maybe. That was more a random thought, than something that would have happened in the past.
Being able to be sure, that tracking tests of core succeed with a plugin, is imho better than not knowing it.

@diosmosis
Copy link
Member Author

Failure tests could be added to core in that case, ones that simulate broken plugin behavior and make sure the tracker survives? And if it's really an issue that plugin JS can somehow break core tracker JS, core tests can be grouped together (if possible to do a module within a module in qunit) into a core one which is simply run with another tests:run-js command before the --plugin=PluginName one. Though it's hard to see what could actually go wrong given core tracker code should not interact with plugin tracker code directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review For pull requests that need a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants