Skip to content

Split comments on blank lines #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2019
Merged

Split comments on blank lines #9

merged 1 commit into from
Jul 3, 2019

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Apr 29, 2018

Ini files often contains documentation for settings that are commented out.

In the example below, the description of instance_id should obviously not be included in the description of api_service_url.

This PR changes the parser, so that comments are broken on empty lines.

Example:

; If you use this Matomo instance over multiple hostnames, Matomo will need to know
; a unique instance_id for this instance, so that Matomo can serve the right custom logo and tmp/* assets,
; independently of the hostname Matomo is currently running under.
; instance_id = stats.example.com

; The API server is an essential part of the Matomo infrastructure/ecosystem to
; provide services to Matomo installations, e.g., getLatestVersion and
; subscribeNewsletter.
api_service_url = http://api.matomo.org

@sgiehl sgiehl mentioned this pull request Jul 9, 2018
Closed
@tsteur
Copy link
Member

tsteur commented Jul 3, 2019

Makes sense 👍

@tsteur tsteur merged commit 4cf2d9d into matomo-org:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c960657 @tsteur