Skip to content

exclude encode for username and password #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

exclude encode for username and password #20

wants to merge 2 commits into from

Conversation

peterhashair
Copy link

@peterhashair peterhashair commented Oct 25, 2022 •
edited
Loading

Description:

Fixes : matomo-org/matomo#19899
Hard coded password and username skip encode.

Review

Peter added 2 commits October 26, 2022 10:10
exclude password and username in encode
e85cfde 
exclude password and username in encode
adding tests to username and password
7439b8f 
adding tests to username and password
@sgiehl
Copy link
Member

sgiehl commented Oct 26, 2022

As discussed on slack, those changes won't be much useful. Will prepare another PR to fix that.

@sgiehl sgiehl closed this Oct 26, 2022
@sgiehl sgiehl deleted the excludepassword branch October 26, 2022 12:06
@sgiehl sgiehl mentioned this pull request Oct 26, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid escaping of characters other than "
2 participants
@peterhashair @sgiehl