Skip to content

Test enhancement #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

peter279k
Copy link
Contributor

Changed log

  • Add php-7.2 and php-7.3 tests on Travis CI build.
  • The satooshi/php-coveralls package is deprecated, and using the php-coveralls/php-coveralls instead.
  • Using the vendor/bin/phpunit to execute PHPUnit.
  • To support future stable PHPUnit version easily, upgrading the PHPUnit to ^4.8.36 version.
  • Using the PHPUnit class namespace.
  • According to the PHPUnit fixture reference, it should be the protected setUp method.

@Findus23
Copy link
Collaborator

Findus23 commented Nov 6, 2019

Hi,

While you are on it, would it be easily possible to also add php-7.4 tests everywhere?

Thanks

@peter279k
Copy link
Contributor Author

Hi,

While you are on it, would it be easily possible to also add php-7.4 tests everywhere?

Thanks

Hi @Findus23, thanks for your reply.

The opinion is good, but it seems that the php-7.4 is not stable version on Travis CI build now.

IMHO, the php-7.4 will be included on the next PR once the Travis CI is supported currently.

@tsteur
Copy link
Member

tsteur commented Nov 6, 2019

awesome @peter279k very much appreciated again

@tsteur tsteur merged commit 6dec8e1 into matomo-org:master Nov 6, 2019
@peter279k peter279k deleted the test_enhancement branch November 7, 2019 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants