-
Notifications
You must be signed in to change notification settings - Fork 25
apply more encoding w/ tests #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@diosmosis not sure what problem you are trying to solve with the changes, but seems the tests are now failing on PHP 5.3.3 only. Not sure if that is relevant any longer. Maybe we could simply discontinue support for PHP 5.3 for this lib... |
@sgiehl we recently merged a pr that fixed some output, in it it was seen that some fields will not escape for unsafe output allowing the INI to be injected (unless escaped by the caller). this was meant to fix that before releasing a new version of the component. The build fix should be simple. |
ok. makes sense. Just out of curiosity: Is there a reason why we don't filter/escape |
👍 didn't think of that, will look into that too |
@sgiehl updated |
Co-authored-by: Stefan Giehl <stefan@matomo.org>
Co-authored-by: Stefan Giehl <stefan@matomo.org>
No description provided.