Skip to content

apply more encoding w/ tests #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2021
Merged

apply more encoding w/ tests #17

merged 4 commits into from
Apr 20, 2021

Conversation

diosmosis
Copy link
Member

No description provided.

@diosmosis diosmosis requested review from sgiehl and flamisz April 16, 2021 01:04
@sgiehl
Copy link
Member

sgiehl commented Apr 16, 2021

@diosmosis not sure what problem you are trying to solve with the changes, but seems the tests are now failing on PHP 5.3.3 only. Not sure if that is relevant any longer. Maybe we could simply discontinue support for PHP 5.3 for this lib...

@diosmosis
Copy link
Member Author

@sgiehl we recently merged a pr that fixed some output, in it it was seen that some fields will not escape for unsafe output allowing the INI to be injected (unless escaped by the caller). this was meant to fix that before releasing a new version of the component. The build fix should be simple.

@sgiehl
Copy link
Member

sgiehl commented Apr 16, 2021

ok. makes sense. Just out of curiosity: Is there a reason why we don't filter/escape " in values? If I see that correctly, that might also break the output, won't it?

@diosmosis
Copy link
Member Author

👍 didn't think of that, will look into that too

@diosmosis
Copy link
Member Author

@sgiehl updated

diosmosis and others added 2 commits April 19, 2021 17:14
Co-authored-by: Stefan Giehl <stefan@matomo.org>
Co-authored-by: Stefan Giehl <stefan@matomo.org>
@sgiehl sgiehl added this to the Current sprint milestone Apr 20, 2021
@sgiehl sgiehl merged commit 188dbef into master Apr 20, 2021
@sgiehl sgiehl deleted the more-encoding branch April 20, 2021 06:37
@innocraft-automation innocraft-automation removed this from the Current sprint milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants