Catch a parse error in case cache file does not get written correctly #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids getting a message like this in the UI: `syntax error, unexpected '=>' (T_DOUBLE_ARROW), expecting ')'` Instead we return false so the cache gets written again. Not sure if otherwise it would even leak potential data as it shows part of the broken part of the cache. Also it makes the app more stable.
|
Once we no longer support PHP 5 we could enable it by default and no longer detect if the class exists |
|
LGTM Could a test maybe added? |
|
Added test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids getting a message like this in the UI:
syntax error, unexpected '=>' (T_DOUBLE_ARROW), expecting ')'Instead we return false so the cache gets written again. Not sure if otherwise it would even leak potential data as it shows part of the broken part of the cache. Also it makes the app more stable.