Support wildcards in IPv6 address ranges #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support analogously to IPv4, '*' can replace a single group of digits and must appear at the end of the address. As part of the implementation, reject previously misinterpreted IPv4 addresses which included digits in the same group as a wildcard character (e.g. `192.168.1*.1*2`, `192.168.1.2**`) or included both wildcards and a subnet size (e.g. `192.168.*.*/24`).
|
Note: I do not think the test failures are related to this code. They appear to be in |
|
Thank you for the Pull request, we will try to review it for the next release 2.16.2 matomo-org/matomo#10058 |
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for wildcard characters in IPv6 address ranges, as discussed in matomo-org/matomo#9411. The support is analogous to IPv4 where
*can replace a single group of digits and must appear at the end of the address.This implementation rejects some previously allowed but unintended (and poorly behaved) IPv4 address ranges, such as ones which included digits in the same group as a wildcard character (e.g.
192.168.1*.1*2,192.168.1.2*) or included both wildcards and a subnet size (e.g.192.168.*.*/24). It also requires the subnet size to be numeric. If either of these is contentious, I can rework/remove them or submit as a separate PR.Thanks for considering,
Kevin
fix matomo-org/matomo#9411