Skip to content

Improving tests for IP class #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

peter279k
Copy link
Contributor

Changed log

  • Add white filter lists for developers and this can help them to evaluate code covers.
  • Add some test cases for IP::isInRange, IP::isInRanges, IP::fromBinaryIP and IP::fromStringIP methods.

@tsteur
Copy link
Member

tsteur commented Nov 13, 2019

Cheers @peter279k very appreciated

@tsteur tsteur merged commit b0510fe into matomo-org:master Nov 13, 2019
@peter279k peter279k deleted the improve_code_covers branch November 13, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants