Skip to content

Code cleanup #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 24, 2025
Merged

Code cleanup #807

merged 16 commits into from
Apr 24, 2025

Conversation

rgoldberg
Copy link
Contributor

Code cleanup:

  • Use new macOS library code based on macOS version
  • Fix Swift 6.1 concurrency errors & warnings
  • Replace unnecessary types with global computed vars
  • Remove unnecessary protocols
  • Remove unnecessary parameter labels
  • Rename files, types, functions, properties, variables
  • Inline single-use variables
  • Use map() instead of for loop
  • Use Self where possible
  • Reorder code
  • Other minor code cleanup

Resolve #804

Change types from `String` to `Self`.

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…dApps: [InstalledApp]` parameters.

Move app uninstall code from deleted `SoftwareMapAppLibrary.swift` to `Uninstall.swift`.

Refactor `SpotlightSoftwareMap.installedApps()` as global `installedApps`.

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Remove `SimpleInstalledApp`.

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg rgoldberg added the 🧽 chore Administrative task: documentation, build, test, release, git, etc. label Apr 24, 2025
@rgoldberg rgoldberg added this to the 2.2.0 milestone Apr 24, 2025
@rgoldberg rgoldberg self-assigned this Apr 24, 2025
@rgoldberg rgoldberg merged commit 16852cd into mas-cli:main Apr 24, 2025
5 checks passed
@rgoldberg rgoldberg deleted the 804-code-cleanup branch April 24, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 chore Administrative task: documentation, build, test, release, git, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code cleanup
1 participant