Fixes #48 - make find() constexpr in C++11 #49
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for pairs of `basic_string_view`s, using the `basic_string_view::starts_with()` method.
|
@martinmoene Oh, btw, I also replaced a gratuitous tab with a space. |
martinmoene
added a commit
that referenced
this pull request
Feb 13, 2022
commit d934b1ac5b8c4ad30222d5fa89d610f74e1b005a Author: Eyal Rozenberg <eyalroz1@gmx.com> Date: Sat Feb 12 21:10:58 2022 +0200 Naive implementation of a `constexpr` alternative to `std::search()` for pairs of `basic_string_view`s, using the `basic_string_view::starts_with()` method.
|
So, if this is no longer relevant - shall we close ? |
|
Yes, indeed, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A naive implementation of a
constexpralternative tostd::search()for pairs ofbasic_string_views, using thebasic_string_view::starts_with()method.Note: Have not implemented this for
rfind(); it would make sense to do both. Have also not touched the copyright notice.