fix: can not select Chinese font family name. #1901
Conversation
| handleSelect (value) { | ||
| if (/^[_A-z0-9]+((-|\s)*[_A-z0-9])*$/.test(value)) { | ||
| if (/^[^\s]+((-|\s)*[^\s])*$/.test(value)) { |
There was a problem hiding this comment.
@Jocs I think you forgot to edit the preferences/schema.json file to allow all font families. When doing so, you should remove the regex completely and implement a proper XSS protection on the editor (renderer) to prevent bad font names. The attack vector is no very high but it's still a file-based Cross-Site Scripting when we don't verify the font family.
An unexpected error occurred in the main process |
Description
[Description of the bug or feature]
This change is