Skip to content

Add tooltip to format tool bar #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 26, 2019
Merged

Add tooltip to format tool bar #1516

merged 8 commits into from
Oct 26, 2019

Conversation

Jocs
Copy link
Member

@Jocs Jocs commented Oct 23, 2019

Q A
Bug fix? yes
Fixed tickets #1515
License MIT

Description

[Description of the bug or feature]

--

Please, don't submit /dist files with your PR!


This change is Reviewable

@Jocs Jocs requested a review from fxha October 23, 2019 06:43
@Jocs Jocs requested a review from fxha October 24, 2019 03:48
@Jocs Jocs mentioned this pull request Oct 24, 2019
11 tasks
@fxha
Copy link
Contributor

fxha commented Oct 24, 2019

mt_overlay_hover

@Jocs The tool-tip is not fully visible on first line.

@Jocs
Copy link
Member Author

Jocs commented Oct 25, 2019

The tool-tip is not fully visible on first line.

I didn't find a better to solve this bug only by css. maybe we can solve it latter, do you have any idea?

@fxha
Copy link
Contributor

fxha commented Oct 25, 2019

@Jocs I like the old design/text more than the current one. I don't really know what to do with this information as a user (ok it's a shortcut in macOS style but IDK).

@Jocs
Copy link
Member Author

Jocs commented Oct 25, 2019

I like the old design/text more than the current one.

Do you think it's no need to add tooltip to format tool bar or no need to add shortcut?

@fxha
Copy link
Contributor

fxha commented Oct 25, 2019

I think it's a good idea but it's should be text. Showing a shortcut only without information is a not the best way to go. What about the HTML5 title attribute that is positioned by browser?

@Jocs
Copy link
Member Author

Jocs commented Oct 25, 2019

Showing a shortcut only without information is a not the best way to go.

I think tooltip with shortcut is necessary, some people will not always remember the shortcut of of each menu item, title attribute with delay and without good UI.

@fxha
Copy link
Contributor

fxha commented Oct 25, 2019

Why not just show <title> <shortcut> if you want shortcuts too. We also have the command palette soon for better navigation. Could get or calculate the window offset of the format overlay to show the tooltip at the bottom?

@Jocs
Copy link
Member Author

Jocs commented Oct 26, 2019

Why not just show <title> if you want shortcuts too.

Do you mean put description + shortcut in the title attribute of element?

Could get or calculate the window offset of the format overlay to show the tooltip at the bottom?

Some complicated, I feel that for the tooltip, to do the work, it is superfluous.

@fxha
Copy link
Contributor

fxha commented Oct 26, 2019

Do you mean put description + shortcut in the title attribute of element?

Yes exactly.

@Jocs
Copy link
Member Author

Jocs commented Oct 26, 2019

@fxha Add title attribute and remove the tooltip.

@Jocs Jocs merged commit ea054df into develop Oct 26, 2019
@Jocs Jocs deleted the fix-1515 branch October 26, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants