Skip to content

Fix the download section anchor #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Fix the download section anchor #1440

merged 1 commit into from
Oct 4, 2019

Conversation

p16i
Copy link
Contributor

@p16i p16i commented Oct 3, 2019

Q A
Bug fix? yes (typo in README.md)
New feature? no
BC breaks? no
Deprecations? no
New tests added? not needed
Fixed tickets N/A
License MIT

Description

The anchor to download section isn't linked properly. The link should use #download-and-installation, not #download-and-install.

--

Please, don't submit /dist files with your PR!

@Jocs
Copy link
Member

Jocs commented Oct 4, 2019

Thanks very much for your PR, you also need to update the docs download link in /docs/i18n/.

@p16i
Copy link
Contributor Author

p16i commented Oct 4, 2019

@Jocs oh, sorry for that. I didn't check it through.

Updated: I've fixed those in docs/i18n.

@Jocs
Copy link
Member

Jocs commented Oct 4, 2019

@heytitle Thanks and merged.

@Jocs Jocs merged commit cc63cf8 into marktext:develop Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants