Skip to content

Feat: add link tools: unlink and jump #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2019
Merged

Feat: add link tools: unlink and jump #1357

merged 1 commit into from
Sep 24, 2019

Conversation

Jocs
Copy link
Member

@Jocs Jocs commented Sep 23, 2019 •
edited
Loading

Q A
New feature? yes
License MIT

Add two buttons when hover link. unlink and jump.

  • unlink will change the link to text.
  • jump will open the link when click.

This change is Reviewable

@Jocs Jocs requested a review from fxha September 23, 2019 07:29
@Jocs Jocs merged commit 1ef0d01 into develop Sep 24, 2019
@fxha
Copy link
Contributor

fxha commented Sep 24, 2019

@Jocs I think we should add a tool-tip description for the two buttons like for the image viewer.

@fxha fxha deleted the open-link branch September 24, 2019 17:39
@Jocs
Copy link
Member Author

Jocs commented Sep 25, 2019

@fxha Ok, I'll add in other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxha fxha fxha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jocs @fxha