Skip to content

Cycle through tabs #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2019
Merged

Cycle through tabs #1283

merged 2 commits into from
Aug 19, 2019

Conversation

fxha
Copy link
Contributor

@fxha fxha commented Aug 17, 2019

Q A
New feature? yes
Fixed tickets #1124
License MIT

Description

Added new shortcuts for tab management:

Id Default Description
tabsCycle CmdOrCtrl+Tab Cycle through tabs
tabsSwitchToLeft CmdOrCtrl+PageUp Switch tab to the left
tabsSwitchToRight CmdOrCtrl+PageDown Switch tab to the right

resolves #1124

@fxha fxha requested a review from Jocs August 17, 2019 10:54
@yougotwill
Copy link

yougotwill commented Aug 17, 2019

@fxha Just a thought but laptop keyboards don't always have PageUp and PageDown (MacBooks for example). Assuming custom keyboard shortcuts aren't being implemented for the next release, I would suggest adding one more shortcut to cycle backwards through the tabs. This behaviour is pretty standard in various browsers and apps I use.

For example:

tabsCycleForward = 'CmdOrCtrl + Tab'
tabsCycleBackward = 'CmdOrCtrl + Shift + Tab'

You could use 'next' and 'previous' instead of 'forward' or 'backward' if you want. 😄

@fxha
Copy link
Contributor Author

fxha commented Aug 17, 2019

Thanks @yougotwill for you feedback! I think that's a good idea to add another backward shortcut.

Assuming custom keyboard shortcuts aren't being implemented for the next release

You can find more about key bindings here. It is available since v0.13.x or v.0.14.0.

@Jocs Jocs merged commit 1ab8388 into develop Aug 19, 2019
@fxha fxha deleted the tab-switching-shortcut branch August 19, 2019 11:54
@Nahcirn
Copy link

Nahcirn commented Jan 3, 2024

@fxha Not sure if this is intended behaviour or not, but these two shortcuts seem to do the same thing:

Id Default Description
tabsCycle CmdOrCtrl+Tab Cycle through tabs
tabsSwitchToRight CmdOrCtrl+PageDown Switch tab to the right

I think it would be great if "tabsSwitchToRight" actually moved the tab's position. I.e. If it's currently the first tab, moving it to the right would make it the second tab.

@YanMiaoW
Copy link

@fxha @Nahcirn move current tab left or right is important. I really need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab switching shortcut please
5 participants