feature: add support ResourceTemplates to mcptest package #449

Slach · 2025-06-25T17:47:19Z

Description

Fixes #436

New feature (non-breaking change that adds functionality)

Checklist

My code follows the code style of this project
I have performed a self-review of my own code
I have added tests that prove my fix is effective or that my feature works
I have updated the documentation accordingly

Summary by CodeRabbit

New Features
- Added support for registering resource templates with the server, enabling dynamic resource handling based on URI patterns.
Tests
- Introduced a new test to verify correct handling and response for resource templates, including argument extraction and URI parsing.

… tests

coderabbitai · 2025-06-25T17:47:38Z

"""

Walkthrough

The changes extend the mcptest.Server to support registering and handling resource templates. New methods allow adding single or multiple resource templates with handlers, and the server startup process now registers these templates. A test case verifies the correct handling and response for a resource template.

Changes

Files Changed	Summary
mcptest/mcptest.go	Added `ServerResourceTemplate` struct, methods for adding resource templates, integrated template registration into server startup.
mcptest/mcptest_test.go	Added test `TestServerWithResourceTemplate` to verify resource template handling, argument extraction, and response correctness.

Assessment against linked issues

Objective	Addressed	Explanation
Add support for registering resource templates and handlers in `mcptest.Server` (#436)	✅
Provide `AddResourceTemplate` method to register a template and handler (#436)	✅
Ensure resource templates are handled and tested in the test server (#436)	✅

Possibly related PRs

mark3labs/mcp-go#54: Modifies core MCP server code to support RFC 6570 URI templates and changes resource template matching logic, directly relating to resource template handling.
mark3labs/mcp-go#56: Changes internal representation and JSON marshaling of URI templates, which is relevant to resource template registration and handling.
"""

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e85125 and 2f0e9a6.

📒 Files selected for processing (1)

mcptest/mcptest_test.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

mcptest/mcptest_test.go

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8f5b048 and c9bdf2a.

📒 Files selected for processing (2)

mcptest/mcptest.go (3 hunks)
mcptest/mcptest_test.go (1 hunks)

🔇 Additional comments (5)

mcptest/mcptest.go (4)

26-26: LGTM: Field addition follows existing pattern.

The addition of resourceTemplates []ServerResourceTemplate to the Server struct is consistent with the existing fields for tools, prompts, and resources.

110-114: LGTM: Struct definition follows established pattern.

The ServerResourceTemplate struct correctly combines a mcp.ResourceTemplate with its handler function, following the same pattern as ServerTool, ServerPrompt, and ServerResource.

116-127: LGTM: Methods follow consistent naming and implementation patterns.

Both AddResourceTemplate and AddResourceTemplates methods follow the established patterns used by the existing AddTool/AddTools, AddPrompt/AddPrompts, and AddResource/AddResources methods. The implementation is correct and consistent.

146-148: LGTM: Template registration follows existing pattern.

The resource template registration in the Start method correctly follows the same pattern used for registering tools, prompts, and resources with the underlying MCP server.
mcptest/mcptest_test.go (1)

198-201: Verify URI template creation approach.

The JSON unmarshaling approach for creating URITemplate seems unusual. Please verify this is the correct way to instantiate a URITemplate in the mcp-go library.
#!/bin/bash
# Search for URITemplate usage patterns in the codebase
ast-grep --pattern 'URITemplate{$$$}' 
ast-grep --pattern '$_.UnmarshalJSON($$$)'
rg -A 3 -B 3 "URITemplate"

mcptest/mcptest_test.go

Slach · 2025-06-26T10:49:09Z

@ezynda3 code rabbit review passed, could you run CI/CD and merge PR?

mcptest/mcptest_test.go

Slach · 2025-07-01T14:54:15Z

@ezynda3 i fixed your review comments, could you approve CI/CD?

Slach added 5 commits June 25, 2025 20:47

feat: implement AddResourceTemplate and add resource template test

77970c4

fix: use local ServerResourceTemplate type in mcptest

4e3a1d8

fix: replace NewURITemplate with UnmarshalText for URI template creation

2af60c4

fix: correct URITemplate unmarshaling and err variable declaration in…

c371d83

… tests

fix: improve resource template argument extraction in test handler

c9bdf2a

coderabbitai bot reviewed Jun 25, 2025

View reviewed changes

mcptest/mcptest_test.go Show resolved Hide resolved

mcptest/mcptest_test.go Outdated Show resolved Hide resolved

Slach added 2 commits June 26, 2025 07:26

test: add assertions to verify URI template argument population

9ad9552

simplify TestServerWithResourceTemplate logic and increase test coverage

8e85125

ezynda3 requested changes Jun 28, 2025

View reviewed changes

mcptest/mcptest_test.go Outdated Show resolved Hide resolved

changes after code review mark3labs#449 (comment)

2f0e9a6

ezynda3 merged commit 251da13 into mark3labs:main Jul 1, 2025
4 checks passed

rafaeljusto mentioned this pull request Jul 9, 2025

enhc(server): allow adding multiple resource templates at once #483

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feature: add support ResourceTemplates to mcptest package #449

feature: add support ResourceTemplates to mcptest package #449

Uh oh!

Slach commented Jun 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 25, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Slach commented Jun 26, 2025

Uh oh!

Uh oh!

Slach commented Jul 1, 2025

Uh oh!

Uh oh!

Uh oh!

feature: add support ResourceTemplates to mcptest package #449

feature: add support ResourceTemplates to mcptest package #449

Uh oh!

Conversation

Slach commented Jun 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Slach commented Jun 26, 2025

Uh oh!

Uh oh!

Slach commented Jul 1, 2025

Uh oh!

Uh oh!

Uh oh!

Slach commented Jun 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)