Issue 400 fix #406

ozzyozbourne · 2025-06-18T19:22:28Z

Description

Fixes nil pointer issue in the examples

Fixes #400

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
MCP spec compatibility implementation
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Code refactoring (no functional changes)
Performance improvement
Tests only (no functional changes)
Other (please describe):

Checklist

My code follows the code style of this project
I have performed a self-review of my own code
I have added tests that prove my fix is effective or that my feature works
I have updated the documentation accordingly

Summary by CodeRabbit

Refactor
- Adjusted the order of client initialization for stdio transport to start the client immediately after creation. This does not affect user-facing behavior.

coderabbitai · 2025-06-18T19:22:34Z

Walkthrough

The change adjusts the initialization sequence in examples/simple_client/main.go by moving the client start call (c.Start(ctx)) earlier in the code path for the stdio transport case, immediately after client creation. The later, common start call is removed, affecting only the stdio transport flow.

Changes

Files	Change Summary
examples/simple_client/main.go	Moved `c.Start(ctx)` to immediately after stdio client creation; removed later start call; error handling for start remains unchanged.

Assessment against linked issues

Objective	Addressed	Explanation
Start the client before setting up logging to fix nil pointer problem (#400)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Possibly related PRs

Create sample client #265: Introduces the initial simple_client example, including client creation and start logic, which is directly affected by the current PR's changes to the client start sequence.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a077d27 and a5d90c7.

📒 Files selected for processing (1)

examples/simple_client/main.go (1 hunks)

🔇 Additional comments (2)

examples/simple_client/main.go (2)

57-60: Good fix for stdio client initialization timing.

Moving the client start call immediately after creation for stdio transport makes sense, especially since the stderr logging setup that follows likely requires an active client connection.

38-90: Verify that HTTP client initialization still works correctly.

The stdio client is now started immediately after creation, but there's no visible start call for the HTTP client in this code path. Please ensure that HTTP clients are either:

Started elsewhere in the codebase, or

Don't require explicit starting before use, or

Are started automatically during the Initialize() call

This verification is important to prevent introducing a regression in the HTTP transport path while fixing the stdio issue.
#!/bin/bash
# Description: Search for other client start calls and HTTP client usage patterns
# Expected: Find where HTTP clients are started or confirm they don't need explicit starting

echo "=== Searching for other client.Start() calls ==="
rg -A 3 -B 3 "\.Start\(" --type go

echo "=== Searching for HTTP client initialization patterns ==="
rg -A 10 -B 5 "NewStreamableHTTP\|HTTP.*transport" --type go

echo "=== Searching for client interface definition to understand Start() requirement ==="
ast-grep --pattern 'type $_ interface {
  $$$
  Start($_) $_
  $$$
}'

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ozzyozbourne added 2 commits June 18, 2025 15:16

fixed nil error

ec43595

Merge branch 'mark3labs:main' into issue_400_fix

a5d90c7

ezynda3 merged commit 93176e8 into mark3labs:main Jun 19, 2025
4 checks passed

coderabbitai bot mentioned this pull request Aug 26, 2025

fix: prevent double-starting stdio transport in client #564

Open

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue 400 fix #406

Issue 400 fix #406

Uh oh!

ozzyozbourne commented Jun 18, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 18, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Issue 400 fix #406

Issue 400 fix #406

Uh oh!

Conversation

ozzyozbourne commented Jun 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Possibly related PRs

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

ozzyozbourne commented Jun 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)