Avoid using newline as a completion separator #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling the _completionTests_complete function in a subshell, the trailing newlines are removed by the shell. Therefore if the script mistakenly includes an empty completion at the end, we would not detect that bug. See spf13/cobra#1691 With this commit, we use a space to separate the completions, so an empty one will be detected (extra space). Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the
_completionTests_completefunction in a sub-shell, the trailing newlines are removed by the shell. Therefore, if the script we are testing mistakenly includes an empty completion at the end, we would not detect that bug.See spf13/cobra#1691
With this commit, we use a space to separate the completions, so an empty one will be detected (extra space).
With this change we can see the tests failing before spf13/cobra#1691 and start to pass again when spf13/cobra#1691 is applied
/cc @scop