Skip to content

Fix <ReferenceArrayInput> does not accept alwaysOn prop #10863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2025
Merged

Fix <ReferenceArrayInput> does not accept alwaysOn prop #10863

merged 2 commits into from
Jul 29, 2025

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jul 29, 2025

Problem

<ReferenceArrayInput> extends an old and unused InputProps interface.

Fixes #10859, #10862

Solution

  • Remove the obsolete InputProps interface
  • Make ReferenceArrayInputProps extends the correct InputProps interface
  • Add stories to showcase using <ReferenceArrayInput> as a filter

How To Test

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@djhi djhi added the RFR Ready For Review label Jul 29, 2025
@djhi djhi requested a review from Madeorsk July 29, 2025 12:21
Madeorsk
Madeorsk requested changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@Madeorsk Madeorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obsolete InputProps is still referenced in

react-admin/packages/ra-core/src/controller/input/ReferenceArrayInputBase.stories.tsx

Line 12 in 91630b2

import { InputProps } from '../../form/types';

@djhi
Copy link
Collaborator Author

djhi commented Jul 29, 2025

The obsolete InputProps is still referenced in

react-admin/packages/ra-core/src/controller/input/ReferenceArrayInputBase.stories.tsx

Line 12 in 91630b2

import { InputProps } from '../../form/types';

Not sure why github don't show it but I fixed the story

@djhi djhi requested a review from Madeorsk July 29, 2025 13:49
@Madeorsk Madeorsk merged commit 71a4327 into master Jul 29, 2025
15 checks passed
@Madeorsk Madeorsk deleted the fix-reference-array-input-always-on branch July 29, 2025 13:56
@djhi djhi added this to the 5.10.1 milestone Jul 29, 2025
@djhi djhi mentioned this pull request Jul 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madeorsk Madeorsk Madeorsk approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Milestone
5.10.1
Development

Successfully merging this pull request may close these issues.

ReferenceArrayInput TypeScript error with alwaysOn prop
2 participants
@djhi @Madeorsk