Skip to content

Introduce <ReferenceArrayInputBase> #10833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 9, 2025
Merged

Introduce <ReferenceArrayInputBase> #10833

merged 9 commits into from
Jul 9, 2025

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jul 8, 2025

Problem

The <ReferenceArrayInput> from ra-ui-materialui actually don't use MUI except for its default children.

Solution

Copy and adapt <ReferenceArrayInput> in ra-core.

How To Test

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)

@djhi djhi added the RFR Ready For Review label Jul 8, 2025
@slax57 slax57 self-requested a review July 9, 2025 09:02
slax57
slax57 requested changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not also add a doc page, just like you dit for ListIterator?

@djhi @slax57
Apply suggestions from code review
986d8a5 
Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
slax57
slax57 reviewed Jul 9, 2025
View reviewed changes
slax57
slax57 approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is OK. As discussed together the doc will be done later.

@slax57 slax57 added this to the 5.10.0 milestone Jul 9, 2025
@slax57 slax57 merged commit 3694427 into next Jul 9, 2025
7 of 10 checks passed
@slax57 slax57 deleted the reference-array-input-base branch July 9, 2025 15:00
@dricholm dricholm mentioned this pull request Jul 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Milestone
5.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@djhi @slax57