-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add support for customization with MUI theme to fields and delete buttons #10770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34885d2
to
f9586d4
Compare
f9586d4
to
a27f996
Compare
djhi
requested changes
Jun 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job otherwise!
…ld default props.
a67e3ad
to
d83e645
Compare
djhi
requested changes
Jun 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
packages/ra-ui-materialui/src/button/DeleteWithUndoButton.stories.tsx
Outdated
Show resolved
Hide resolved
djhi
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some fields, inputs and buttons are not customizable by themes. This adds a way to set custom styles or props on all fields and on delete button.
Solution
Use styled components with a defined name in all fields and inputs.
Current limits:
How To Test
Then view a field, input or button you want to test with and try to change the default theme. For example:
Additional Checks
master
for a bugfix or a documentation fix, ornext
for a feature