-
Notifications
You must be signed in to change notification settings - Fork 142
improve: geotag with exiftool after native geotagging #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process with native parsing first, then ExifTool (the default behaviour)
When running
process
, MT now defaults to using native parsers (exif, camm, gopro, blackvue) before falling back to ExifTool for any failures. This approach leverages our previous speedup work (#722, #729, #731, #721) making native parsing 3-10x faster than ExifTool, while maintaining ExifTool's broad format support.If ExifTool is not found, a warning is printed:
You can specify the path to your ExifTool installation with the
MAPILLARY_TOOLS_EXIFTOOL_PATH
environment variable. When not set, MT searches for ExifTool in your PATH.Unified Geotag Source Options
Reused the same geotag option syntax here but standardized the support for both videos and images:
--geotag_source=exif
expands to{"source": "exif"}
(applies to images only)--geotag_source=native,exiftool_runtime
expands to[{"source": "native"}, {"source": "exiftool_runtime"}]
The
--video_geotag_source
option is now a convenience wrapper for--geotag_source
that always targets videos:--video_geotag_source=exiftool_runtime
expands to{"source": "exiftool_runtime", "filetypes": "video"}