Smartly choose a new layer name to prevent duplicate names #3501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn
requested changes
Oct 17, 2022
f982aec to
f3ebef7
Compare
@bjorn - changes have been made, please check it out 😃 |
Apart from some coding style tweaks, I also made the number start at the most intuitive (in my opinion) value. So if you have two tile layers (regardless of their name) and add a 3rd one, it will prefer to call it "Tile Layer 3" and go upwards from there in case of collisions.
|
@lhiginbotham Thanks! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3452 by attempting to use the default "{Type} Layer {Number}" name, incrementing {Number} if any collisions occur.