fix: Improve Dropdown
component accessibility
#35373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35338
Changes proposed in this PR:
Dropdown
component, adding missing aria attributes and simplifying focus handling:placement
prop to customise the dropdown menu's position per componentonKeyPress
prop fromIconButton
which was only used by theDropdown
component and is not needed anymore now sinceonClick
handles keyboard interactions fineScreencap
This video shows the menu being opened by Enter key first, then Space, then by clicking on the empty space to the right of the "More" button. Each time the menu is navigated briefly and closed via Esc
Screen.Recording.2025-07-14.at.17.34.01.mov