Skip to content

Conversation

diondiondion
Copy link
Contributor

Fixes #35338

Changes proposed in this PR:

  • Fixes keyboard accessibility of Dropdown component, adding missing aria attributes and simplifying focus handling:
  • Makes the "More" menu item take up the whole width of the menu, increasing its click target
  • Adds a placement prop to customise the dropdown menu's position per component
  • Removes deprecated onKeyPress prop from IconButton which was only used by the Dropdown component and is not needed anymore now since onClick handles keyboard interactions fine

Screencap

This video shows the menu being opened by Enter key first, then Space, then by clicking on the empty space to the right of the "More" button. Each time the menu is navigated briefly and closed via Esc

Screen.Recording.2025-07-14.at.17.34.01.mov

@diondiondion diondiondion requested a review from a team July 14, 2025 15:36
@diondiondion diondiondion added this pull request to the merge queue Jul 15, 2025
Merged via the queue into main with commit 82a6ff0 Jul 15, 2025
33 checks passed
@diondiondion diondiondion deleted the dion/improve-more-menu-a11y branch July 15, 2025 08:04
@diondiondion diondiondion added the to backport PR needed to be backported label Jul 17, 2025
SlyEcho pushed a commit to est-social/mastodon that referenced this pull request Jul 28, 2025
@ClearlyClaire ClearlyClaire removed the to backport PR needed to be backported label Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility with "more" button on sidebar
3 participants