Skip to content

fix: Fix outdated icon in notifications permissions banner #35193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

fix: Fix outdated icon in notifications permissions banner #35193

merged 1 commit into from
Jun 26, 2025

Conversation

diondiondion
Copy link
Contributor

@diondiondion diondiondion commented Jun 26, 2025 •
edited
Loading

Changes proposed in this PR:

  • Fixes outdated column settings icon in the notifications permissions banner
  • Adds an aria-label to the icon so the message also makes sense to screen reader users
  • Converts NotificationsPermissionsBanner component to TypeScript

Thanks to @CyberTailor for raising this here.

Screenshots

Before After
Screenshot 2025-06-26 at 14 56 55 Screenshot 2025-06-26 at 15 07 31

@diondiondion diondiondion requested a review from a team June 26, 2025 13:13
@diondiondion diondiondion mentioned this pull request Jun 26, 2025
Merged
@Gargron Gargron enabled auto-merge June 26, 2025 13:21
@Gargron Gargron added this pull request to the merge queue Jun 26, 2025
Merged via the queue into main with commit 9576434 Jun 26, 2025
31 of 32 checks passed
@Gargron Gargron deleted the dion/fix-outdated-notification-banner-icon branch June 26, 2025 13:37
@ClearlyClaire ClearlyClaire mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diondiondion @Gargron